Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature): Converting Twitter_Unfollowers script to Npm Package #1336

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

(feature): Converting Twitter_Unfollowers script to Npm Package #1336

wants to merge 3 commits into from

Conversation

Jagrutiti
Copy link
Contributor

@Jagrutiti Jagrutiti commented Mar 12, 2022 •
edited

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Fixes #1327

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation Update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@ghost
Copy link

ghost commented Mar 12, 2022 •
edited by ghost

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@Jagrutiti
Copy link
Contributor Author

Hi @HarshCasper the package is published here.

Changes I would like to propose:

  1. Not sure how the bearer-key should be added. Maybe prompt users as we prompt them to enter their username. Any suggestions would be helpful here.
  2. Add new keywords in package.json. For now, I have added only twitter.

When we import the package after installing, it asks for dependency to be met:

  1. prompt-sync
  2. needle

I will add them in package.json.

Will release a minor version once all the changes are finalized.

@HarshCasper
Copy link
Owner

Hi @Jagrutiti

We can prompt them in the same way when we ask them to enter their username. We can also ask them to export the API keys as TWITTER_BEARER_KEY before using the package. Let me know if that sounds helpful!

You can add keywords like unfollower, twitter-api, twitter-utility as well.

@Jagrutiti
Copy link
Contributor Author

Hi @HarshCasper. Published 1.0.1 version of the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshCasper HarshCasper Awaiting requested review from HarshCasper

@iamakkkhil iamakkkhil Awaiting requested review from iamakkkhil

@vybhav72954 vybhav72954 Awaiting requested review from vybhav72954

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Node script to npm packages
2 participants
@Jagrutiti @HarshCasper