Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Karakal Premier League data #2

Open
HaydenMacDonald opened this issue Oct 3, 2020 · 0 comments
Open

Support for Karakal Premier League data #2

HaydenMacDonald opened this issue Oct 3, 2020 · 0 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@HaydenMacDonald
Copy link
Owner

HaydenMacDonald commented Oct 3, 2020

Currently squashinformr does not support web scraping for Karakal Premier League events. These tournaments have a unique competition format: team-based competition split by rounds. As a result, the tournament pages on SquashInfo have vastly different HTML formatting to all other events.

It would be great if someone could help me build support for these events, as they often feature prominent players. This would involve adding logic to get_tournament_players, get_tournament_matches, get_tournament_games. I don't have a specified style guide for contributions, but I would prefer that you use tidyverse methods and extensive commenting 🙂

See below for an example of the Karakal Premier League tournament page.

karakal
SquashInfo url

@HaydenMacDonald HaydenMacDonald added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 3, 2020
@HaydenMacDonald HaydenMacDonald removed the enhancement New feature or request label Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant