Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confuse about open method #1

Open
DouglasHennrich opened this issue Jan 3, 2016 · 0 comments
Open

Confuse about open method #1

DouglasHennrich opened this issue Jan 3, 2016 · 0 comments

Comments

@DouglasHennrich
Copy link

I was looking into your code on open method and I think you may be confuse on this line:

if (navigationWindow === null || drawer)

It will be conflicted with android... cause on android we don't want to open just another window in front of drawer, we want to add it as a child of our home window

if we pass a new window to be home's child and keep drawer, these line:

if (drawer){
  ...
// Reset our local stack refrance
windows = [];
}

Will reset our stack... it shouldn't reset our window's child stack because we want to use the drawer on the childs too, not only on home window. We still need to set it as centerWindow, but we can't reset the stack, because when we close our child, it won't will bring our home back.
I don't know if you understand what i'm saying or I understood wrong the logic to use drawer.

maybe a look into this Android's drawer example should explain
Thanks =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant