Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deck Tracker not Launching Hearthstone #3708

Closed
JiveArtifact opened this issue Jun 23, 2018 · 10 comments
Closed

Deck Tracker not Launching Hearthstone #3708

JiveArtifact opened this issue Jun 23, 2018 · 10 comments

Comments

@JiveArtifact
Copy link

JiveArtifact commented Jun 23, 2018

Bug report

Expected Behavior

I expected to press the "Launch Hearthstone" button and have the Hearthstone app open with the deck tracker active.

Actual Behavior

Nothing happened - the "Start Hearthstone" button was gray for a second but then returned to its original state without the Hearthstone app having been opened.

Steps to reproduce behavior

Just clicking on start Hearthstone.
I've tried the other steps for it not working, such as changing the path, but none of it has worked so far. -

@CLJunge
Copy link
Contributor

CLJunge commented Jun 24, 2018

Same for me. Debugged HDT, no errors. Maybe a Battle.net issue?

@azeier
Copy link
Member

azeier commented Jun 24, 2018

Looks like blizzard changed something about the procotols. Don't have time to investigate right now, but this is the command that is no longer working: https://github.com/HearthSim/Hearthstone-Deck-Tracker/blob/master/Hearthstone%20Deck%20Tracker/Utility/HearthstoneRunner.cs#L52

@CLJunge
Copy link
Contributor

CLJunge commented Jun 24, 2018

I'll take a look.

@azeier
Copy link
Member

azeier commented Jun 24, 2018

The "name" hasn't changed. battlenet://WTCG still opens the hearthstone tab on the launcher.

@CLJunge
Copy link
Contributor

CLJunge commented Jun 24, 2018

Executing 'Battle.net.exe --exec="WTCG"' launches Hearthstone successfully, but i'm not sure if that's a desired solution since we have to know the installation directory.

@azeier
Copy link
Member

azeier commented Jun 24, 2018

Since we can still launch the battle.net client via battlenet:// the easiest fix is probably:

  1. Run battlenet:// (already happens)
  2. Wait for the process (already happens)
  3. Get Battle.net.exe path via the running process
  4. Run <full_path>/Battle.net.exe --exec="WTCG"

I'm not sure how to best work around the Battle.net.beta client though. Is that the same executable?

@azeier
Copy link
Member

azeier commented Jun 24, 2018

I guess we actually know whether we find the Battle.net or Battle.net.beta process and thus find the correct executable path regardless. The above approach will work.

@CLJunge
Copy link
Contributor

CLJunge commented Jun 24, 2018

The command is actually 'Battle.net.exe --exec="launch WTCG"'. Just installed the beta version and the default and beta client are now running under the same name, so that shouldn't be a problem. I'll implement a fix.

@azeier
Copy link
Member

azeier commented Jun 24, 2018

Gonna leave this open actually until the release it out, to prevent duplicates.

There should be a release around noon PST tomorrow.

@azeier
Copy link
Member

azeier commented Jun 24, 2018

Fixed with v1.6.8

@azeier azeier closed this as completed Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants