Allow option() override by FetchContent #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheStormN
commented
Feb 17, 2024
| @@ -24,6 +24,11 @@ include( GNUInstallDirs ) | |||
|
|
|||
| get_directory_property( has_parent PARENT_DIRECTORY ) | |||
|
|
|||
| if (POLICY CMP0077) | |||
There was a problem hiding this comment.
This makes it compatible with older CMake versions which do not support this policy.
|
@HowardHinnant I know you are not promoting CMake support, but in general it does work and tbh I don't think that just copying over some files into a project is a nice way for 3rd party dependency management. My ask is to consider merging this PR, so my(and other people) life can become a bit easier. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #812