Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split model and kernel operations parts into separate classes #5

Open
parkag opened this issue Feb 24, 2015 · 0 comments
Open

Split model and kernel operations parts into separate classes #5

parkag opened this issue Feb 24, 2015 · 0 comments
Assignees

Comments

@parkag
Copy link
Member

parkag commented Feb 24, 2015

There are two parts of KCSD method that can be turned into separate classes.
First part is model where we make some assumptions about the measurement process. This is currently handled by init_model() function, but it could be moved out into a separate class.

Two classes could be introduced:

  • BaseModel as a readable template to override
  • specific model that handle the current model-related operations of KCSD

The second part would be the KCSD-specific operations - calculating all the kernels.

The benefit of this approach is that model could be now used as the only parameter of the KCSD method. Models and KCSD parts could be developed independently. To handle a different model one would only need to write his own model class and instead of searching through the whole KCSD code.

@parkag parkag self-assigned this Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant