Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashlets allow the user to run Javascript code #4959

Closed
nilmerg opened this issue Dec 7, 2022 · 0 comments · Fixed by #4955
Closed

Dashlets allow the user to run Javascript code #4959

nilmerg opened this issue Dec 7, 2022 · 0 comments · Fixed by #4955
Assignees
@nilmerg
Labels
area/dashboard Affects the dashboard bug Something isn't working
Milestone
2.11.3

Comments

@nilmerg
Copy link
Member

nilmerg commented Dec 7, 2022

Describe the bug

Dashlets allow the user to run Javascript code.

To Reproduce

  1. Create a new dashlet
  2. Use data:data:data:text/html,<script>alert(document.location);</script> as url
  3. Open the dashlet on the dashboard

Expected behavior

The url is not accepted upon storage.

Additional context

https://rt.icinga.com/Ticket/Display.html?id=43449
@nilmerg nilmerg self-assigned this Dec 7, 2022
@nilmerg nilmerg mentioned this issue Dec 7, 2022
Merged
@nilmerg nilmerg added bug Something isn't working area/dashboard Affects the dashboard labels Dec 7, 2022
@nilmerg nilmerg added this to the 2.11.3 milestone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilmerg nilmerg

Labels
area/dashboard Affects the dashboard bug Something isn't working
Projects
None yet
Milestone
2.11.3
Development

Successfully merging a pull request may close this issue.

External URLs still allowed in dashlets Icinga/icingaweb2
1 participant
@nilmerg