Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IgxGrid): Add checks in case cell is no longer in view. #14158

Merged
merged 3 commits into from May 16, 2024

Conversation

MayaKirova
Copy link
Contributor

Closes #14116

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@mddragnev
Copy link
Member

@MayaKirova I think we also need a PR for 16.1.x

@MayaKirova
Copy link
Contributor Author

@mddragnev I think 16.1.x already has all the commits: https://github.com/IgniteUI/igniteui-angular/pull/14220/commits

@mddragnev
Copy link
Member

@mddragnev I think 16.1.x already has all the commits: https://github.com/IgniteUI/igniteui-angular/pull/14220/commits

Isnt this a different issue and PR?

@MayaKirova
Copy link
Contributor Author

MayaKirova commented May 14, 2024

@mddragnev I think 16.1.x already has all the commits: https://github.com/IgniteUI/igniteui-angular/pull/14220/commits

Isnt this a different issue and PR?

Yes. My bad. Here's one for 16.1x.: #14223

@dkamburov dkamburov added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels May 15, 2024
@kdinev kdinev merged commit c227fae into master May 16, 2024
5 of 6 checks passed
@kdinev kdinev deleted the mkirova/fix-14116 branch May 16, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid version: 18.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grids: Cell node might be undefined after scroll - error in crud service updateCell
5 participants