Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When grid is inside a container with display: contents it does not span the full 100% of the height. #14138

Open
MayaKirova opened this issue Apr 22, 2024 · 1 comment · May be fixed by #14141
Assignees
Labels
🐛 bug Any issue that describes a bug ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@MayaKirova
Copy link
Contributor

Description

When grid is inside a container with display: contents it does not span the full 100% of the height.

  • igniteui-angular version:
  • browser:

Steps to reproduce

  1. Open sample: https://stackblitz.com/edit/tchxxa

Result

There is white space below the grid.

Expected result

It should expand to 100% height.

@damyanpetev
Copy link
Member

damyanpetev commented Apr 26, 2024

Small correction on the actual result:
It's not that the Grid doesn't span to 100% - it does. Actually, since the display: grid handles the internal structure the actual grid tbody is also correctly stretched to fill in the space. It's the tbody content container that's restricted by the calculated height.

So there's white space inside the grid tbody, where there shouldn't be :)

In a sense that's a bit related to the work being done for #14015 (new resize observer of the tbody at the very least should allows us to just measure directly in most cases) or at least part of the calculations we're should attempt to simplify or remove after. Looking at the fix, seems like it's more of a check for the calculation, but still.
Edit: Task in question to simplify body calculations: #14048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants