Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web components projects should use the general TypeScriptFileUpdate.ts #983

Open
dafo opened this issue Jan 24, 2022 · 4 comments
Open

Web components projects should use the general TypeScriptFileUpdate.ts #983

dafo opened this issue Jan 24, 2022 · 4 comments

Comments

@dafo
Copy link
Collaborator

dafo commented Jan 24, 2022

Description

Currently web components projects use own TypeScriptFileUpdate.ts file, located inside their own folder. It duplicates much of the logic inside the "general" file placed under "packages/core/typescript".
All projects must use the general file. It should be updated to support generation of project different than Angular.
N. B. The logic should be platform agnostic. Where we check for Ng stuff - we should set it as parameters instead of looking what platform the generated project is.

We should refactor the addRoute method. This method is actually doing two things, at least. It adds routes as well as it adds imports. We should try to split this into two separate methods. Note, to do this we may need to create separate visitor for imports and routes. - #1060 (comment)

  • Ignite UI CLI version: 9.x.x
  • Framework: Web Components
  • Project type: igc-ts
@dafo
Copy link
Collaborator Author

dafo commented Oct 7, 2022

#1060 (comment)

@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 6, 2023
@dafo dafo reopened this Nov 14, 2023
Copy link

There has been no recent activity and this issue has been marked inactive.

Copy link

There has been no recent activity and this issue has been marked inactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants