Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate EntityMapper from Crayfish-Commons #2220

Open
whikloj opened this issue Mar 27, 2023 · 0 comments
Open

Separate EntityMapper from Crayfish-Commons #2220

whikloj opened this issue Mar 27, 2023 · 0 comments
Assignees

Comments

@whikloj
Copy link
Member

whikloj commented Mar 27, 2023

We need to require Crayfish-Commons for Islandora because of the EntityMapper. But that means we are intermingling two instances of Symfony and can cause issues like Islandora/Crayfish-Commons#59

We should split the EntityMapper out, require it in Islandora and Milliner (the only places it's needed) and then upgrade Crayfish to use a recent version of Symfony.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant