Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace WaveBuilder by Smart Wave #114

Closed
sbordes opened this issue May 14, 2014 · 1 comment
Closed

Replace WaveBuilder by Smart Wave #114

sbordes opened this issue May 14, 2014 · 1 comment
Assignees
Milestone

Comments

@sbordes
Copy link
Member

sbordes commented May 14, 2014

Avoid all builders (complex to write) and update WaveBase to add chainable method.

Before:
ShowModelWaveBuilder.create()
.childrenPlaceHolder(this.application.getRootNode().getChildren())
.showModelKey(getFacade().getUiFacade().buildKey((Class) this.application.getFirstModelClass()))
.build();

After:
WaveBase.create()
.relatedClass(ShowModelCommand.class)
.waveGroup(CALL_COMMAND)
.waveBean(
DisplayWaveBean.create()
.childrenPlaceHolder(this.application.getRootNode().getChildren())
.showModelKey(getFacade().getUiFacade().buildKey((Class) this.application.getFirstModelClass())
);
Longer but the showModelWaveBuilder is removed and could be replaced by a simple method returning :
WaveBase.create()
.relatedClass(ShowModelCommand.class)
.waveGroup(CALL_COMMAND)

@sbordes sbordes added this to the 8.0.0 milestone May 14, 2014
@sbordes sbordes self-assigned this May 14, 2014
@sbordes sbordes closed this as completed May 27, 2014
@sbordes
Copy link
Member Author

sbordes commented May 27, 2014

Pushed on Workbench branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant