Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FXMLModel should be released too #124

Closed
sbordes opened this issue Jul 21, 2014 · 0 comments
Closed

FXMLModel should be released too #124

sbordes opened this issue Jul 21, 2014 · 0 comments
Assignees
@sbordes
Labels
bug
Milestone
7.7.3

Comments

@sbordes
Copy link
Member

sbordes commented Jul 21, 2014

When the fxml root node is detached from its parent (and so from the scene), the Model.release method should be called.

It was already done in AbstractView
@sbordes sbordes added this to the 7.7.3 milestone Jul 21, 2014
@sbordes sbordes self-assigned this Jul 21, 2014
sbordes added a commit that referenced this issue Jul 21, 2014
@sbordes
Fix #124 call release method when the fxml root node is detached
ba3d3b1
@sbordes sbordes closed this as completed Jul 21, 2014
@sbordes sbordes added the bug label Jul 22, 2014
sbordes added a commit that referenced this issue Aug 27, 2014
@sbordes
Fix #124 call release method when the fxml root node is detached
ad73cc3 
Conflicts:
	org.jrebirth.af/core/src/main/java/org/jrebirth/af/core/ui/fxml/AbstractFXMLObjectModel.java
@sbordes sbordes mentioned this issue Nov 20, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordes sbordes

Labels
bug
Projects
None yet
Milestone
7.7.3
Development

No branches or pull requests
1 participant
@sbordes