Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android AArch64 build #4831

Open
1 task done
stevenxxiu opened this issue Apr 10, 2024 · 8 comments
Open
1 task done

Android AArch64 build #4831

stevenxxiu opened this issue Apr 10, 2024 · 8 comments
Assignees
Labels
🚀 feat New feature 🤔 info needed Further information is requested

Comments

@stevenxxiu
Copy link

Code of Conduct

  • I agree to follow this project's Code of Conduct

What would you like to see changed/added?

Hi, I see there's a https://github.com/JanDeDobbeleer/oh-my-posh/releases/download/v19.20.0/posh-android-arm. Could there be an Android AArch64 build? I tried https://github.com/JanDeDobbeleer/oh-my-posh/releases/download/v19.20.0/posh-linux-arm64, and parts of my config can cause it to crash.

Thanks so much for this btw. I just set up my config.

@stevenxxiu
Copy link
Author

@JanDeDobbeleer
Copy link
Owner

@stevenxxiu this makes no sense so help me out here. aarch64 is arm64 v9. We build for v7 which should be compatible. But, in your termux build, oh-my-posh is built using linux-amd64, so I'm rather confused as to why that one should work.

@JanDeDobbeleer JanDeDobbeleer added the 🤔 info needed Further information is requested label May 21, 2024
@stevenxxiu
Copy link
Author

stevenxxiu commented May 22, 2024

When I last tested https://github.com/JanDeDobbeleer/oh-my-posh/releases/download/v19.20.0/posh-android-arm, I saw that the command and git segments crashed. I don't have something that's exactly reproducible atm, as my Termux PR got merged and I'm using that.

Where did you see me using linux-amd64? Are you talking about https://github.com/termux/termux-packages/pull/19747/files? Termux should be building it with each supported architecture.

@JanDeDobbeleer
Copy link
Owner

I saw that the command and git segments crashed

@stevenxxiu can you show me the logs?

Where did you see me using linux-amd64

It's what termux_setup_golang installs and I don't see any GOARCH or GOARM values being set anywhere.

@stevenxxiu
Copy link
Author

@stevenxxiu can you show me the logs?

I don't have that atm. I didn't save it when it crashed. Do those segments work for you in Termux? If you can't get it to crash I can try to test out my config later.

It's what termux_setup_golang installs and I don't see any GOARCH or GOARM values being set anywhere.

This is set in https://github.com/termux/termux-packages/blob/5bdbfc6b1a134a46e70708706f627e80da2d8d7e/scripts/build/toolchain/termux_setup_toolchain_26b.sh.

@JanDeDobbeleer
Copy link
Owner

@stevenxxiu ok, cool. That shows some additional flags as we compile for that architecture already. I can adjust our build towards that. Also, I don't have an Android device ;-)

@JanDeDobbeleer
Copy link
Owner

@stevenxxiu can you try with v20.2.0

@stevenxxiu
Copy link
Author

stevenxxiu commented May 25, 2024

It still crashes.

The minimal reproducible examples are pretty small:

- type: command

oh_my_posh_command_error_log.txt

- type: git

oh_my_posh_git_error_log.txt

You could install some Android emulator to test it if you want.

I'm not too fussed about not fixing this, as I got it to build and work in Termux. One benefit is it will show people how it's built in a more minimal way than the Termux packages repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feat New feature 🤔 info needed Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants