Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WriteById returns 204 instead of 404 with WolverineGet #766

Open
DurinMusicspear opened this issue Feb 21, 2024 · 0 comments
Open

WriteById returns 204 instead of 404 with WolverineGet #766

DurinMusicspear opened this issue Feb 21, 2024 · 0 comments

Comments

@DurinMusicspear
Copy link

DurinMusicspear commented Feb 21, 2024

Using WriteById should return 404 as described here: https://martendb.io/documents/aspnetcore.html#single-document

That works with ASP.Net MinimalAPI but with WolverineGet it returns 204 instead.

Example that returns 204:

[WolverineGet("/warehouse/{warehouseId}")]
public static Task Get(Guid warehouseId, IQuerySession session, HttpContext context)
    => session.Json.WriteById<Warehouse>(warehouseId, context);

Tested with Wolverine 1.19 and Marten 6.4.1

@jeremydmiller jeremydmiller transferred this issue from JasperFx/wolverine Mar 5, 2024
@jeremydmiller jeremydmiller transferred this issue from JasperFx/marten Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant