Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Firefox theme loading #132

Closed

Conversation

theaquarium
Copy link
Collaborator

Fixes #128.

For future reference (and maybe this'll show up in a Google search for someone someday):
In Firefox, the onload listener in link tags appears to be run not just when the tag is loaded, but also whenever the tag is marked as myTag.disabled = false.

In our case, this caused an infinite loop whenever dark mode was loaded, since the onload listener would mark the tag as disabled and then would be reenabled by the updateTheme function.

@theaquarium
Copy link
Collaborator Author

#141 does this better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox hangs on page loading
1 participant