Skip to content
This repository has been archived by the owner on Jan 4, 2020. It is now read-only.

Ability to run master without tagged releases #152

Open
ashfurrow opened this issue Dec 9, 2017 · 2 comments
Open

Ability to run master without tagged releases #152

ashfurrow opened this issue Dec 9, 2017 · 2 comments

Comments

@ashfurrow
Copy link
Contributor

Creating a new Marathon package currently requires at least one tagged release:

➜  Harvey git:(danger-swift) ✗ marathon run Test.swift
💥  Could not resolve the latest version for package at 'https://github.com/ashfurrow/danger-swiftlint.git'
👉  Make sure that the package you're trying to add is reachable, and has at least one tagged release

It'd be cool if this wasn't a requirement. Thanks!

@JohnSundell
Copy link
Owner

Hey @ashfurrow 👋

I agree, it would be really cool 👍 But as far as I know this is not supported by the Swift Package Manager, for remote packages it requires a tagged version. And since Marathon is essentially a wrapper around SPM it inherits this requirement.

One possible way of solving it could be that Marathon simply clones master of a given repo, and then makes a tag locally and makes the script point to the local clone. Not sure if it's worth the complexity though 🤔

@orta
Copy link
Collaborator

orta commented Dec 10, 2017

Not worth it IMO, but it's a bit sucky downstream.

I wonder if the // marathon: https://github.com/danger/danger.git syntax could be expanded to include branches? then you can use the branch master and pass that to SPM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants