Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change shell from bash to zsh #51

Open
tapi opened this issue Jun 1, 2020 · 2 comments
Open

Change shell from bash to zsh #51

tapi opened this issue Jun 1, 2020 · 2 comments

Comments

@tapi
Copy link

tapi commented Jun 1, 2020

Since MacOS now ships with zsh I think it would make sense to change the shell used by ShellOut to match. I was just bitten by an issue where file globbing behaviours were different between the two and debugging it made no sense since it worked when run manually.

Alternatively the shell could be made configurable. Happy to make the change, just wanted to start the discussion first.

@ghost
Copy link

ghost commented Nov 21, 2020

I hit this recently too. Agree it would be good to be able to assign or override the launchPath and similar used by the underlying process to better support zsh.

However, in the mean time I have just added an abstracted Process class named ZSHProcess which will ensure it uses the things I need.

@leoidiaz
Copy link

Didn't know there was an open issue for this.
I submitted a PR for a quick way to add this option last month. Don't know if it will ever get merged but feel free to fork off my version if it's of any use!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants