Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some depwarns and ambiguities #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix some depwarns and ambiguities #22

wants to merge 1 commit into from

Conversation

timholy
Copy link
Member

@timholy timholy commented Aug 18, 2021

Fixes #20

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #22 (62de34b) into master (75f8eb9) will decrease coverage by 19.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
- Coverage   89.47%   70.27%   -19.21%     
===========================================
  Files           1        1               
  Lines          38       37        -1     
===========================================
- Hits           34       26        -8     
- Misses          4       11        +7     
Impacted Files Coverage Δ
src/FFTViews.jl 70.27% <100.00%> (-19.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f8eb9...62de34b. Read the comment docs.

@timholy
Copy link
Member Author

timholy commented Aug 18, 2021

Will require JuliaArrays/OffsetArrays.jl#255 to pass tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FFTViews breaks with loaded (PaddedViews | OffsetArrays)
1 participant