Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluto output display #66

Open
KronosTheLate opened this issue Feb 3, 2021 · 5 comments
Open

Pluto output display #66

KronosTheLate opened this issue Feb 3, 2021 · 5 comments

Comments

@KronosTheLate
Copy link

Is it possible to make

"When working in a Jupyter notebook (which can display rich HTML representations), SampleBufs will show a waveform display and allow you to listen to the buffer using your browser's WebAudio support."

the case in pluto notebooks as well? (I am assuming it is not, I haven't tested)

@ssfrr
Copy link
Collaborator

ssfrr commented May 8, 2021

The way SampledSignals outputs the fancy display is no longer the way that Jupyter wants things done - it should really be implemented as an extension to Jupyter that handles that mime type, rather than injecting javascript.

@KronosTheLate
Copy link
Author

So this is working now!
image

However, I can't hear a thing when I click play :/
I have ofc tested that other things actually make sound. Any idea why?

@KronosTheLate
Copy link
Author

I just tried it again, and now I works. I have no idea why.
So the only thing missing is adding it to the docs!

@rob-luke
Copy link
Member

rob-luke commented Dec 7, 2021

What needs to be added to the docs? Did you have to install anything special? Or does it work out of the box?

@KronosTheLate
Copy link
Author

KronosTheLate commented Dec 7, 2021

Sorry for not being clear - I was thinking that since there are section on both the REPL display, and Jupyter notebooks, there should now be a section added for Pluto - simply showing what it looks like, and stating that a sound signal can be played directly.

The waveform is not shown in pluto ATM - I had to plot it seperately. A simply display of the waveform, just like in the REPL (or the even prettier one in Jupyter) would also be very nice.

Also, the readme is long enough that I feel that it could be benificial to put it into a documentation page. I have edited docs before, but I have not set it up from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants