Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of Savitzky-Golay filter #379

Open
ararslan opened this issue Oct 6, 2020 · 1 comment
Open

Inclusion of Savitzky-Golay filter #379

ararslan opened this issue Oct 6, 2020 · 1 comment

Comments

@ararslan
Copy link
Member

ararslan commented Oct 6, 2020

I have a pretty basic implementation of Savitzky-Golay filtering based on that in SciPy (BSD-3 licensed so no problems). Seems like this could be a good home for it, but I'm not sure where exactly. Is the distinction that it's typically used for smoothing rather than discarding unwanted frequencies important enough that it should not be adapted to fit into the framework used by filt, and instead live as its own thing?

@galenlynch
Copy link
Member

I think you could put it in the filt framework. However if you're going to make a type that contains the parameters of the Savitzky-Golay filtering, it would be problematic to make it a subtype of FilterCoefficients: many functions such as freqz have methods for generic FilterCoefficients that try to convert the filter into other filter types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants