Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move requires usage to extension #400

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

KristofferC
Copy link
Contributor

@KristofferC KristofferC commented Mar 13, 2023

The requires usage in this package has been profiled to cause some overhead. This moves this to extensions to avoid the overhead on 1.9:

1.8:

julia> using JSON, RecipesBase, SentinelArrays, StructTypes

julia> @time using CategoricalArrays # runs the `@require` blocks
  0.604061 seconds (1.06 M allocations: 63.916 MiB, 88.10% compilation time: 67% of which was recompilation)

1.9:

julia> using JSON, RecipesBase, SentinelArrays, StructTypes

julia> @time using CategoricalArrays # loads the extensions
  0.059438 seconds (299.68 k allocations: 21.276 MiB, 4.53% compilation time)

@vtjnash
Copy link
Contributor

vtjnash commented Apr 17, 2023

bump?

@andreasnoack andreasnoack merged commit 5251f03 into JuliaData:master Apr 17, 2023
@KristofferC KristofferC deleted the kc/extensions branch April 17, 2023 17:49
@KristofferC
Copy link
Contributor Author

@andreasnoack, could we get a new release with this?

@andreasnoack
Copy link
Member

Have there been unintended consequences of these upgraded or can I just make it a patch release?

@KristofferC
Copy link
Contributor Author

Should be fine with a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants