Improve PerspectiveCamera rotation (upvector)

[louisponet]

GLAbstraction.jl/src/GLCamera.jl

Line 496 in 7f20d62

rotation = rotate_cam(theta_v, right_v, Vec3f0(0,0,1), dir)

Hi,
I think Vec3f(0,0,1) in this line should be changed to up_v. Previously the camera remained with the same upvector, causing left/right rotations to feel very weird after a while.
(also this was what I mentioned in my last comment in JuliaGL/GLVisualize.jl#190 , I edited that comment)

grtz

[jaakkor2]

Any reason not to do the change?

I agree that if up-vector flips, then left-right rotations do not feel natural.

[SimonDanisch]

Yes I think so, I should have added a comment there since I don't completely remember myself... But I think the rotations was getting super funky without a fixed upvector.

[louisponet]

If it's of any worth, I changed it locally on my pc since my post and haven't noticed any particular funkyness. Maybe I'm missing something though.