Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguating overlapping colorscheme names #28

Open
asinghvi17 opened this issue Apr 2, 2020 · 1 comment
Open

Disambiguating overlapping colorscheme names #28

asinghvi17 opened this issue Apr 2, 2020 · 1 comment

Comments

@asinghvi17
Copy link
Contributor

There's some discussion going on in PlotUtils about switching to ColorSchemes as a provider of color gradients. However, there are some overlaps in PlotUtils' gradient names; for example,:rainbow exists in misc and colorcet.

It would be nice to have a way we all agree on to handle that; either by manually ensuring that there are no namespace conflicts, or some other system.

(Also, quick question - is the library threadsafe? It looks like all the colorschemes are stored in a global Dict, which may lead to some issues. I'll test it in a bit.)

@cormullion
Copy link
Member

Threadsafe? I don't know, sorry, and will watch your analysis with interest if not understanding ... :)

As for the namespace issue, I'd guess that more people have used PlotUtils than ColorSchemes, so perhaps the ones in PlotUtils should take precedence. (Although the PlotUtils:rainbow scheme is just a renamed ColorSchemes.rainbow_bgyr_35_85_c73_n256` I think.)

I'm in favour of keeping ColorSchemes simple, rather than getting complicated like PlotUtils... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants