Print longer arrays without newlines #305
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis error is just a Pkg download glitch |
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
==========================================
+ Coverage 92.60% 92.74% +0.13%
==========================================
Files 6 6
Lines 311 317 +6
==========================================
+ Hits 288 294 +6
Misses 23 23
Continue to review full report at Codecov.
|
|
This shouldn't be merged as-is. Needs rethinking. |
|
Any chance this can be revived? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving JSON files with long arrays results in very long documents currently because of all the newlines.
This only prints newlines after array elements if the length of the array is > 5.
i.e.
instead of
Fixes #291