Fix DEFAULT_PARSERCONTEXT, speed up parsing. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately this was never updated in JuliaIO#280 to be the correct default, and so has been wrong ever since introduction.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
=======================================
Coverage 99.35% 99.35%
=======================================
Files 7 7
Lines 466 466
=======================================
Hits 463 463
Misses 3 3 ☔ View full report in Codecov by Sentry. |
sjkelly
reviewed
Jan 4, 2024
| @@ -415,9 +415,9 @@ function unparameterize_type(T::Type) | |||
| end | |||
|
|
|||
| # Workaround for slow dynamic dispatch for creating objects | |||
| const DEFAULT_PARSERCONTEXT = ParserContext{Dict{String, Any}, Int64, false, nothing}() | |||
| const DEFAULT_PARSERCONTEXT = ParserContext{Dict{String, Any}, Int64, true, nothing}() | |||
There was a problem hiding this comment.
If we change the default to be a non-strict spec, we will certainty want to update the docs and make a version bump. The Python docs may serve as a guide for communicating this: #280 (comment)
There was a problem hiding this comment.
Unless I'm missing something, this is a default in the sense that there is a fast path for it. This change doesn't change the result but is merely a performance improvement. If you look further down you'll see that these are the default parameters for parse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this was never updated in #280 to be the correct default, and so has been wrong ever since that pr.
#263 suggest significant improvements, I don't see as big an improvement but still substantial.