Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate generic seekend method #183

Open
nhz2 opened this issue Mar 19, 2024 · 0 comments
Open

Deprecate generic seekend method #183

nhz2 opened this issue Mar 19, 2024 · 0 comments

Comments

@nhz2
Copy link
Member

nhz2 commented Mar 19, 2024

As noted by @jakobnissen in #149 (comment) and @Marlin-Na in #109 there is no way to implement a generic seekend method that doesn't process the whole file.

This is because after calling seekend on a decompressing stream, position should return the uncompressed data size.

I propose deprecating the generic seekend method and removing it in the next breaking release.

Another option would be to implement a generic seek and seekend using the generic seekstart and skip, but as noted in #149 (comment) this could be surprising as seek is expected to be reasonably fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant