Skip to content
This repository has been archived by the owner on May 4, 2019. It is now read-only.

Avoid copying input Array{Union{T, Null}} in DataArray{T} constructor #291

Open
nalimilan opened this issue Oct 21, 2017 · 0 comments
Open

Comments

@nalimilan
Copy link
Member

We currently make a copy of an Array{Union{T, Null}} input to an Array{T} because the data field of DataArray should be Array{T}. We should use low-level Julia API once available to access the underlying value part of the input as an Array{T} (for isbits types) in an unsafe way, since we know we will never access null entries. See this discussion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant