0004346: detect collision only for common group mode

JumpMind · Apr 21, 2020 · 88428e7 · 88428e7
1 parent 6b8c92f
commit 88428e7
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RouterService.java b/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RouterService.java
@@ -948,7 +948,7 @@ protected int insertDataEvents(ProcessInfo processInfo, ChannelRouterContext con
         Map<String, OutgoingBatch> batches = null;
         long loadId = -1;
         boolean dataEventAdded = false;
-        boolean firstTimeForGroup = false;
+        boolean detectGroupCollision = false;
         int numberOfDataEventsInserted = 0;
         final List<OutgoingBatch> batchesToInsert = new ArrayList<OutgoingBatch>();
         final List<OutgoingBatch> batchesToRoute = new ArrayList<OutgoingBatch>();
@@ -968,7 +968,8 @@ protected int insertDataEvents(ProcessInfo processInfo, ChannelRouterContext con
             if (batches == null) {
                 batches = new HashMap<String, OutgoingBatch>();
                 batchesByGroups.put(groupKey, batches);
-                firstTimeForGroup = true;
+            } else {
+                detectGroupCollision = true;
             }
         } else {
             batches = context.getBatchesByNodes();
@@ -1007,7 +1008,7 @@ protected int insertDataEvents(ProcessInfo processInfo, ChannelRouterContext con
                                 nodeId, batch.getChannelId(), batches.values());
                     }
 
-                    if (useCommonMode && !firstTimeForGroup) {
+                    if (detectGroupCollision) {
                         throw new CommonBatchCollisionException("Collision detected for group " + nodeIds.hashCode()
                             + " when routing nodes " + nodeIds);
                     }