-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canonical repo address is inconsistent with module path #3
Comments
@KillingSpark Could you help me review this issue? Thx :p |
I hate that capitalized letters in a github name cause this much trouble when using go, I had this issue a while ago with my own and others packages too. I could fix this, but to be completely honest, I do not recommend to use this package but to use the one of klauspost here. It has better decompression performance and provides compression too. |
@KillingSpark Thank you for your reply! I'll take a look at the other package you recommended. : D |
I should propably update the Readme with that disclaimer tbh :D
|
The github.com/KillingSpark/sparkzstd repo used the module, but the module path is set to github.com/killingspark/sparkzstd.
This means that the canonical github repo address now conflicts with canonical go import packages.
It is now very easy for downstream consumers (which used GOPATH mode) to accidentally add imports to upper-case
"github.com/KillingSpark/sparkzstd/..."
packages. This will create many pitfalls and break the module users. They may encounter errors:Solution
Rename the module path to ”github.com/KillingSpark/sparkzstd”.
https://github.com/KillingSpark/sparkzstd/blob/master/go.mod#L1
The text was updated successfully, but these errors were encountered: