Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all supported Kubernetes resources fallback is covered in tests #5933

Open
2 tasks
Tracked by #5854
czeslavo opened this issue Apr 25, 2024 · 0 comments
Open
2 tasks
Tracked by #5854
Labels
release/required it is required that this be resolved before releasing
Milestone

Comments

@czeslavo
Copy link
Contributor

czeslavo commented Apr 25, 2024

Make sure that all Kubernetes resource kinds supported by KIC are covered in the fallback configuration tests. A preferable type of test that will allow simulating any object kind rejection on the Gateway side is an envtest with mocked Kong Admin API server. These tests could also generate golden files with the generated fallback configuration so that we can use them in another test ensuring this configuration gets accepted by a real Gateway instance.

Besides the envtests covering all possible objects, there should also exist an integration test that triggers a well-known failure (e.g. misconfiguring a Service) and ensures the fallback configuration is delivered to the Gateway as expected (turning off webhook validations can be leveraged to enable triggering some cases).

Please also ensure that if a Gateway rejects the generated fallback configuration, KIC will behave as expected (use the last valid config if it was preserved).

Blocked by #5931.

Tasks

  1. 0 of 23
    release/required
    czeslavo
  2. release/required
    programmer04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/required it is required that this be resolved before releasing
Projects
None yet
Development

No branches or pull requests

1 participant