Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inventory creation #79

Open
cnlg-lanl opened this issue May 10, 2024 · 3 comments
Open

inventory creation #79

cnlg-lanl opened this issue May 10, 2024 · 3 comments

Comments

@cnlg-lanl
Copy link
Contributor

@jkmacc-LANL Thinking I’m going to start working on the inventory creation function in pisces today. Looks like I created a branch but didn’t start on it. Do you have an opinion on whether this goes into the stations.py file or do you think it would be better in it’s own file?
@jkmacc-LANL
Copy link
Member

Thanks for asking. On the event side of things, I put the logic for converting query things to Catalog things into a separate file since it feels like it has a separate job. Maybe do it in an inventory.py.

@cnlg-lanl
Copy link
Contributor Author

Cool. That's what I remembered the plan being, but figured I'd check.

@cnlg-lanl
Copy link
Contributor Author

@jkmacc-LANL ...I'm digging through the recent obspy updates. It looks like the scaling factor issue in their response file has been fixed in 1.4.1 but not 1.4.0, do we want to make pisces dependent on 1.4.1 since we are adding in response information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkmacc-LANL @cnlg-lanl