Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: improve job launcher interface #578

Open
adammoody opened this issue Nov 2, 2023 · 0 comments
Open

scripts: improve job launcher interface #578

adammoody opened this issue Nov 2, 2023 · 0 comments
Assignees
Labels
Projects

Comments

@adammoody
Copy link
Contributor

adammoody commented Nov 2, 2023

The JobLauncher interface for launch_run() is ambiguous in that some launchers require the list of nodes to run on (like aprun and mpirun) while others take the list of nodes to avoid (like srun and jsrun). For proper polymorphism, we need to settle on one approach so that the interface is consistent across all implementations.

Additionally, let's create a JobLauncherRun class to be returned by launch_run() which will later be passed to wait_run() or kill_run(). This class will represent a launched parallel run, and it will encapsulate the details of the proc and jobid values currently returned by launch_run. It could also provide stdout(), stderr(), and rc() functions so one can query the results of the parallel run.

@adammoody adammoody added this to To do in v3.1 Nov 2, 2023
@adammoody adammoody self-assigned this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
v3.1
To do
Development

No branches or pull requests

1 participant