Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variorum should check for GPU build before calling GPU APIs (eg utilization or get_thermals etc) #454

Open
tpatki opened this issue Jul 21, 2023 · 0 comments

Comments

@tpatki
Copy link
Member

tpatki commented Jul 21, 2023

The for (i = 0; i < P_NUM_PLATFORMS; i++) in the variorum_print_gpu_utilization(void) API should be:

if (VARIORUM_WITH_NVIDIA_GPU || VARIORUM_WITH_AMD_GPU || VARIORUM_WITH_INTEL_GPU)


 for (i = 0; i < P_NUM_PLATFORMS; i++)
    {
#ifdef VARIORUM_WITH_INTEL_GPU
        i = P_INTEL_GPU_IDX;
        break;
#endif
#ifdef VARIORUM_WITH_NVIDIA_GPU
        i = P_NVIDIA_GPU_IDX;
        break;
#endif
#ifdef VARIORUM_WITH_AMD_GPU
        i = P_AMD_GPU_IDX;
        break;
#endif
    }


or something similar

This is a GPU only API and should not be called on other (CPU) platforms. Results in an unimplemented error
@tpatki tpatki changed the title Variorum Print GPU utilization API should not call other platforms Variorum should check for GPU build before calling GPU APIs (eg utilization or get_thermals etc) Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant