Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variable types #524

Closed
wants to merge 4 commits into from
Closed

Update variable types #524

wants to merge 4 commits into from

Conversation

slabasan
Copy link
Collaborator

@slabasan slabasan commented Mar 7, 2024

Description

Fixes #520

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/architecture support (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Build/CI update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please provide hardware architecture specs and
instructions so we can reproduce.

  • Test A: Hardware architecture, machine name, example/test run
  • Test B: Hardware architecture, machine name, example/test run
  • ...

Checklist:

  • I have run ./scripts/check-code-format.sh and confirm my code code follows the style guidelines of variorum
  • I have added comments in my code
  • My changes generate no new warnings (build with -DENABLE_WARNINGS=ON)
  • New and existing unit tests pass with my changes

Thank you for taking the time to contribute to Variorum!

@slabasan slabasan added status-wont-fix and removed status-work-in-progress In progress, not ready to merge. labels Mar 11, 2024
@slabasan
Copy link
Collaborator Author

Not going to fix at this time.

@slabasan slabasan closed this Mar 11, 2024
@slabasan slabasan deleted the update-variable-types branch March 12, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix type in variable declarations
1 participant