Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we support Ruby 2.x? #17

Open
shinokaro opened this issue May 5, 2024 · 3 comments
Open

Should we support Ruby 2.x? #17

shinokaro opened this issue May 5, 2024 · 3 comments

Comments

@shinokaro
Copy link
Collaborator

Should we support Ruby 2,6?
The version of RubyGems attached to Ruby2,6 is 3.0.3.1 and the following warning is reported when running tests in CI:

Your RubyGems version (3.0.3.1) has a bug that prevents `required_ruby_version` from working for Bundler.
Any scripts that use `gem install bundler` will break as soon as Bundler drops support for your Ruby version.
Please upgrade RubyGems to avoid future breakage and silence this warning by running `gem update --system 3.2.3`

Should we support Ruby 2,7?
Ruby 2.6 and 2.7 will no longer be supported from Bundler 2.5.
https://github.com/rubygems/rubygems/blob/master/bundler/CHANGELOG.md#breaking-changes
If we support Ruby 2.7, we will not be able to upgrade the version of Bundler.

@shinokaro
Copy link
Collaborator Author

shinokaro commented May 10, 2024

My opinion is to drop support for Ruby 2.x.

We want to test against all versions of Ruby that we support.
Ruby changes every year and is unstable as an application execution environment.
And we will be maintaining the Gemfile at the time of Ruby 3.4.
That's why you need our support at all times.

In addition, GEM (minitest, hoe), which is required by OCRAN, will also end support for Ruby 2.x in the near future.

Since Ruby on Windows 3.0, strings in ARGV will be UTF-8 (https://bugs.ruby-lang.org/issues/13571).
This solves one of the problems with the handling of multibyte strings in OCRAN.

@shinokaro
Copy link
Collaborator Author

shinokaro commented May 10, 2024

We want to test against all versions of Ruby that we support.

@Largo

@Largo
Copy link
Owner

Largo commented May 10, 2024

Ok, we can drop old Ruby Versions, but make a note in the changelog, so users will now which version still works?

shinokaro added a commit that referenced this issue May 10, 2024
#17
We want to test against all versions of Ruby that we support.
In addition, the gems 'minitest' and 'hoe', which are required by OCRAN, will also end their support for Ruby 2.x in the near future.
shinokaro added a commit that referenced this issue May 16, 2024
#17
Ruby 3.0 and later will be the target of the tests. x64-mingw32 is required in PLATFORMS for testing with Ruby 3.0.
shinokaro added a commit that referenced this issue May 16, 2024
shinokaro added a commit that referenced this issue May 17, 2024
#17
We want to test against all versions of Ruby that we support.
In addition, the gems 'minitest' and 'hoe', which are required by OCRAN, will also end their support for Ruby 2.x in the near future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants