Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Full vote display mode? And what should be the default? #1400

Open
3 tasks done
dessalines opened this issue Feb 24, 2024 · 2 comments
Open
3 tasks done

Add a Full vote display mode? And what should be the default? #1400

dessalines opened this issue Feb 24, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@dessalines
Copy link
Member

dessalines commented Feb 24, 2024

Pre-Flight checklist

  • Did you check to see if this issue already exists?
  • This is a single feature request. (Do not put multiple feature requests in one issue)
  • This is not a question or discussion. (Use https://lemmy.ml/c/jerboa for that)

Describe The Feature Request Below

I have a PR to add these vote display modes to the lemmy back-end.

But we have two unresolved questions:

  1. Should we add a Full mode alongside Score+Downvote ?
  2. What should be the default until the back end gets merged + deployed?

For 1, I don't think its necessary, mainly because I'm trying to avoid this mess: Screenshot_2024-02-12-12-52-32-271-edit_com jerboa_1 .

I removed all this distracting extra unecessary info, and put everything in the node header bar. But should it also show the upvotes alongside score? IE score, upvotes, downvotes, time . IMO that's too much info, and it isn't necessary.

For 2, I think we should switch the default to Score+UpvotePct. It looks the cleanest, and seems to be what most lemmy front-ends are using now.

For reference, here's what these modes look like in jerboa (without full)

Score + Downvote (the current default):
Screenshot_2024-02-14-17-58-41-653-edit_com jerboa debug

Score and Upvote Pct (I'd like this to be the new default):

Screenshot_2024-02-14-17-57-01-796-edit_com jerboa debug

Upvote pct:

Screenshot_2024-02-14-17-57-39-362-edit_com jerboa debug

Upvote pct in list view:

Screenshot_2024-02-14-17-57-52-874-edit_com jerboa debug

Hide all:

Screenshot_2024-02-14-18-12-40-282-edit_com jerboa debug

cc @MV-GH

@dessalines dessalines added the enhancement New feature or request label Feb 24, 2024
@MV-GH
Copy link
Collaborator

MV-GH commented Feb 24, 2024

Yeah I agree with the default change.

But some users do like seeing the upvotes near the arrows. Even tho, it is more visual clutter. And we can add this option easily since all the stuff is still there for it.

So the question is then, do make that Full and remove the Score + downvotes (Do users even want this option)?

Or do we add ScoreDownvotes option to the backend for this?

@dessalines
Copy link
Member Author

But some users do like seeing the upvotes near the arrows. Even tho, it is more visual clutter. And we can add this option easily since all the stuff is still there for it.

I actually did remove the score as a function param to post and comment footer/action bars. Now it only injects your myVote, to color the button. I did that so that item scores can all be shown in one spot, rather than 3 places.

So the question is then, do make that Full and remove the Score + downvotes (Do users even want this option)?

I think the more options the better, and that one is already done, so there's no reason to remove it. I'll just change the name to ScoreAndDownvote, and also add this in my back-end PR.

And I'll add a Full option in a PR (with a screenshot, but it won't be in use until the back-end stuff is done).

dessalines added a commit that referenced this issue Feb 25, 2024
- Also making ScoreAndUpvotePercentage the new default, until these
  get added in the back-end.
- Context #1400
dessalines added a commit that referenced this issue Mar 8, 2024
…1402)

* Upping version.

* Adding ScoreAndUpvote vote display mode.

- Also making ScoreAndUpvotePercentage the new default, until these
  get added in the back-end.
- Context #1400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants