Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Comment wrongly marked as read if it receives any reply. #4566

Closed
5 tasks done
dessalines opened this issue Mar 25, 2024 · 0 comments · Fixed by #4567
Closed
5 tasks done

[Bug]: Comment wrongly marked as read if it receives any reply. #4566

dessalines opened this issue Mar 25, 2024 · 0 comments · Fixed by #4567
Assignees
@dessalines
Labels
bug Something isn't working

Comments

@dessalines
Copy link
Member

Requirements

  • Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a single bug? Do not put multiple bugs in one issue.
  • Do you agree to follow the rules in our Code of Conduct?
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

There is a bug in our create comment code, where it will mark a comment_reply as read, if it receives any reply, when in reality it should only mark it as read if it receives a reply from our user.

This causes missed notifications.

Steps to Reproduce

  1. You receive a comment reply
  2. A different user responds to that reply
  3. That comment_reply is wrongly marked as read

Technical Details

NA

Version

main

Lemmy Instance URL

all
@dessalines dessalines added the bug Something isn't working label Mar 25, 2024
@dessalines dessalines self-assigned this Mar 25, 2024
dessalines added a commit that referenced this issue Mar 25, 2024
@dessalines
Fixing issue with comment replies wrongly marked as read.
942eea9 
- Fixes #4566
@dessalines dessalines mentioned this issue Mar 25, 2024
Merged
dessalines added a commit that referenced this issue Mar 26, 2024
@dessalines
Fixing issue with comment replies wrongly marked as read. (#4567)
7929e77 
* Fixing issue with comment replies wrongly marked as read.

- Fixes #4566

* Elaborating on a comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dessalines dessalines

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing issue with comment replies wrongly marked as read. LemmyNet/lemmy
1 participant
@dessalines