Fixed issue #16460: Unable to update format or questionindex by plugin

Dev : all attributes allowed
LimeSurvey · Jul 29, 2020 · 408683d · 408683d
1 parent c8473f5
commit 408683d
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/application/models/Survey.php b/application/models/Survey.php
@@ -506,14 +506,10 @@ public function afterFindSurvey()
         $event = new PluginEvent('afterFindSurvey');
         $event->set('surveyid', $this->sid);
         App()->getPluginManager()->dispatchEvent($event);
-        // set the attributes we allow to be fixed
-        $allowedAttributes = array('template', 'usecookie', 'allowprev',
-            'showxquestions', 'shownoanswer', 'showprogress', 'questionindex',
-            'usecaptcha', 'showgroupinfo', 'showqnumcode', 'navigationdelay',
-            'expires','startdate','admin','adminemail','emailnotificationto','emailresponseto');
-        foreach ($allowedAttributes as $attribute) {
+        $aAttributes = array_keys($this->getAttributes());
+        foreach ($aAttributes as $attribute) {
             if (!is_null($event->get($attribute))) {
-                $this->{$attribute} = $event->get($attribute);
+                $this->setAttribute($attribute,$event->get($attribute));
             }
         }
         $this->template = Template::templateNameFilter($this->template);