Fixed issue #11502: Popup editor does not launch. Error in DOM naming

Fixed issue: Problem with inserting new subquestions in a postgresql environment. Dev: Added a check to prevent non-numeric id-values to be checked against the database to prevent postgresql type errors
LimeSurvey · Jul 28, 2016 · 480939a · 480939a
1 parent f13c6c4
commit 480939a
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/application/core/Survey_Common_Action.php b/application/core/Survey_Common_Action.php
@@ -164,10 +164,13 @@ private function _addPseudoParams($params)
         // iGroupId/gid can be found with qid/iQuestionId
         if(isset($params['iQuestionId']))
         {
-            $oQuestion=Question::model()->find("qid=:qid",array(":qid"=>$params['iQuestionId']));//Move this in model to use cache
-            if($oQuestion)
-            {
-                $params['iGroupId']=$params['gid']=$oQuestion->gid;
+            if((int) $params['iQuestionId'] >0 )
+            { //Check if the transfered iQuestionId is numeric to prevent Errors with postgresql
+                $oQuestion=Question::model()->find("qid=:qid",array(":qid"=>$params['iQuestionId']));//Move this in model to use cache
+                if($oQuestion)
+                {
+                    $params['iGroupId']=$params['gid']=$oQuestion->gid;
+                }
             }
         }
         // iSurveyId/iSurveyID/sid can be found with gid/iGroupId