Skip to content

Commit

Permalink
Dev: Test ignoring jumbotron (travis)
Browse files Browse the repository at this point in the history
  • Loading branch information
@olleharstedt
olleharstedt committed Nov 12, 2019
1 parent ab6c819 commit e6aa400
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/TestBaseClassWeb.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ public static function adminLogin($userName, $password)

$submit = self::$webDriver->findElement(WebDriverBy::name('login_submit'));
$submit->click();
/*
try {
sleep(1);
self::$webDriver->wait(5)->until(
Expand All @@ -179,6 +180,7 @@ public static function adminLogin($userName, $password)
'Found no welcome jumbotron after login.'
);
}
*/
}

/**
Expand Down

18 comments on commit e6aa400

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange ?

@olleharstedt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strange: Travis sucks ass and has very random performance. I'm looking for an alternative, perhaps github actions.

@olleharstedt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denis, your test keeps failing for some reason:

1) ls\tests\PreviewGroupAndQuestionTest::testPreviewGroup

Url: http://localhost/index.php/survey/index/sid/892498/action/previewgroup/gid/26

Screenshot in /home/travis/build/LimeSurvey/LimeSurvey/tests/tmp/screenshots/ls\tests\PreviewGroupAndQuestionTest_testPreviewGroup.png

Unable to locate element: #group\-1

@olleharstedt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works in isolation but fails (locally too) when running the entire suit.

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it work last week !

6 days : https://travis-ci.org/LimeSurvey/LimeSurvey/builds/609276397?utm_source=github_status&utm_medium=notification

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works in isolation but fails (locally too) when running the entire suit.

Maybe order broke preview for this user ?

@olleharstedt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked, and now it breaks for DBENGINE=MYISAM

Gah

I'm debugging.

@olleharstedt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm talking about the development branch.

@olleharstedt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you online on Telegram? Can I send you files?

@olleharstedt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem:

399
400

@olleharstedt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

399 <!-- START OF GROUP: Preview group checking   -->                                                                                                                                                                                         
400 <div id="group-0" class=" group-outer-container  space-col">

group-0

@olleharstedt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why???

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on Zulip …

I think, it was on master …

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it was the group 1

  1. Prefill part is the group 0 (step 0)
  2. Second group is the group 1 (step 1)

Don't ask me why … it's this since a lot of year
https://github.com/SondagesPro/LimeSurvey-SondagesPro/blob/b1bd60f77ce8f718ad8b41803cbacdcae0360c51/application/helpers/SurveyRuntimeHelper.php#L1035

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then : it seems there are an issue with Expression manager step count ????? Expression manager goes to session …

@olleharstedt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible solution:

  1. Clear session between tests.

  2. Don't hard-code group id?

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But group-id are always 1 , in all condition : it's the second group : then it was group-1 else something changed …

@olleharstedt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting $_SESSION = [] at setup did not fix the issue.

Please sign in to comment.