Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing the update queue in reverse order causes bugs #94

Open
thomasbyersfluent opened this issue Jan 16, 2017 · 1 comment
Open

Comments

@thomasbyersfluent
Copy link

The batchUpdate method processes the update queue in the wrong order which causes bugs in my app.

I am doing an update to remove a component, then the next update deletes an object that's used by the component. Doing this in reverse order means the component attempts to access an undefined object which crashes the app.

I know the source code says this is for performance reasons, but it breaks compatibility with React. If I reverse the order of the updates, my app will no longer work in development where I use React.

Please consider using shift instead of pop.

@Lucifier129
Copy link
Owner

Can you add some codes to reproduce it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants