assemblyline_submit: KeyError: 'submission'

[JordanBarnartt]

I am trying to set up the assemblyline_submit module as packaged with the misp-docker deployment.

After configuration, when I attempt to a URL for enrichment, I receive the error: "Something went wrong, look in the server logs for details"

Looking at the logs of the misp-modules container, I see:

2024-03-10 23:18:03,800 - misp-modules - ERROR - Something went wrong when processing query request
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/misp_modules/__init__.py", line 223, in post
    response = yield tornado.gen.with_timeout(timeout, future)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/tornado/gen.py", line 769, in run
    value = future.result()
            ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/misp_modules/__init__.py", line 210, in run_request
    response = module.handler(q=json_payload)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/misp_modules/modules/expansion/assemblyline_submit.py", line 73, in handler
    sid = submission['submission']['sid']
          ~~~~~~~~~~^^^^^^^^^^^^^^
KeyError: 'submission'

Running the same command manually using the latest version of the assemblyline_client (https://cybercentrecanada.github.io/assemblyline4_docs/integration/python/#submit), there is no "submission" key. "sid" is a key of the submission result itself, so line 73 should just be sid = submission['sid'], I think.