Make sklearn embedding backend auto-select more cautious #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddyheppell
changed the title
MaartenGr
reviewed
May 23, 2024
There was a problem hiding this comment.
Thanks for the PR! I had a few questions/suggestions but other than that it looks good. There is currently an issue with the pipeline as a result of the scikit-learn v1.5 upgrade. To get this pipeline working for you, I would advise implementing the same fix as #2008. That way, we can run the pipeline and see if everything works as intended.
Comment on lines
+143
to
+144
| if verbose: | ||
| logger.info("Automatically selecting lightweight scikit-learn embedding backend as sentence-transformers appears to not be installed.") |
There was a problem hiding this comment.
The if statement is not needed since you already set the logging level right?
| from sklearn.pipeline import make_pipeline | ||
| from sklearn.decomposition import TruncatedSVD | ||
| from sklearn.feature_extraction.text import TfidfVectorizer | ||
| from sklearn.pipeline import Pipeline as ScikitPipeline | ||
|
|
||
| logger = MyLogger("WARNING") |
There was a problem hiding this comment.
This might create duplicates of the logger but I am not entirely sure. I believe this might be related: #1894 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1980
sentence_transformers, select skelarn as it's probably a minimal install. If any other module, re-raise as this is abnormal.select_backendas I think they were quite out of dateI ended up instantiating a new logger for this as it felt better to pass
verbosethan the whole logger.