Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LoggingEvent::getFormattedMessage public #28

Open
javathought opened this issue Jul 2, 2020 · 2 comments
Open

Make LoggingEvent::getFormattedMessage public #28

javathought opened this issue Jul 2, 2020 · 2 comments

Comments

@javathought
Copy link

In tests, I want to make assertions on the message that is generated in the logging system, not the template with positional args with "{}".

It could therefore be hard to test arguments, as it should need creating real instance of objects passed as args to logging, not just text really logged

@valfirst
Copy link

valfirst commented Jul 4, 2020

@javathought you might want to migrate to my fork: https://github.com/valfirst/slf4j-test, the improvement is already released: valfirst#23

@sasuw
Copy link

sasuw commented Aug 16, 2020

I have also created a fork from the project, where the only change currently is that LoggingEvent.getFormattedMessage is public. See https://github.com/sasuw/slf4j-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants