Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Redis Sentinel & authentication & perhaps even TLS #2780

Open
1 of 3 tasks
D1StrX opened this issue Apr 18, 2023 · 4 comments
Open
1 of 3 tasks

Feature: Redis Sentinel & authentication & perhaps even TLS #2780

D1StrX opened this issue Apr 18, 2023 · 4 comments
Labels
type/feature Introduces a new feature

Comments

@D1StrX
Copy link

D1StrX commented Apr 18, 2023

Environment & Version

Environment

  • docker compose
  • kubernetes
  • docker swarm

Is your feature request related to a problem? Please describe.
New to Mailu, but looking at the Helm chart it doesn't seem to support Redis sentinels, external secret reference for DB password or TLS. Is this really the case? Also using Bitnami Redis Helm chart.

Describe the solution you'd like

  • External Redis existing secret reference to the DB password (Must have)
  • Redis Sentinel support (Nice to have)
  • TLS support (Should have)

Additional context
Add any other context or screenshots about the feature request here.
image

From: Mailu/helm-charts#237

@D1StrX D1StrX changed the title Redis Sentinel & authentication & perhaps even TLS Feature: Redis Sentinel & authentication & perhaps even TLS Apr 18, 2023
@nextgens nextgens added the type/feature Introduces a new feature label Apr 19, 2023
@nextgens
Copy link
Contributor

nextgens commented Apr 19, 2023

We've discussed it and would review any PR you would send for this.

The idea is to introduce three new 'advanced' configuration variables that would take redis-URLs as parameters (redis://{username}:{password}@{host}/{db}) and would default to the current behavior.

REDIS_RATELIMIT
REDIS_QUOTA
REDIS_FUZZDB

You'll need to patch the following files:

docs/configuration.rst
core/admin/mailu/configuration.py
core/rspamd/conf/redis.conf
towncrier/newsfragments/2780.feature

And may find the following URLs useful:
https://rspamd.com/doc/configuration/redis.html
https://redis.readthedocs.io/en/stable/connections.html#sentinel-client (see: core/admin/mailu/utils.py)
https://mailu.io/master/contributors/workflow.html

@D1StrX
Copy link
Author

D1StrX commented Apr 19, 2023

Thanks for confirming the idea. As much I would love to contribute, there is only one slightly issue. I am not a developer 😅
Nor have I worked with Redis from a code perspective, which would it make much easier to relate to code.

@fastlorenzo
Copy link
Contributor

The idea is to introduce three new 'advanced' configuration variables that would take redis-URLs as parameters (redis://{username}:{password}@{host}/{db}) and would default to the current behavior.

I would even add the port as well (optional), and make the username/password optional as well (as Mailu doesn't currently support authentication): redis://[{username}:{password}]@{host}[:{port}]/{db}

@sephentos
Copy link

Unfortunately, I can't contribute in terms of code too, but I would also love having at least external Redis support (also in favor of #2616). Offering myself as a tester if needed, just hmu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Introduces a new feature
Projects
None yet
Development

No branches or pull requests

4 participants