Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge graphic does not appear below match details #52

Open
danielholgate opened this issue Jul 12, 2018 · 10 comments
Open

Merge graphic does not appear below match details #52

danielholgate opened this issue Jul 12, 2018 · 10 comments
Labels
bug Something isn't working

Comments

@danielholgate
Copy link

The graphic which shows which elements have been merged/contributed no longer appears after commit c275dbb
effects Chrome and Firefox (other browsers not tested)

The detail screen should look like this:
screen shot 2018-07-12 at 10 39 07 am

but latest demo code instead looks like this (no graphic is shown, but there is a gap where it should display)

screen shot 2018-07-12 at 10 35 28 am

An error is logged in the Chrome developer tools console:
ERROR Error: missing: 3
    at find (sankey.js:48)
    at eval (sankey.js:126)
    at Array.forEach ()
    at computeNodeLinks (sankey.js:122)
    at sankey (sankey.js:64)
    at SmartMasteringDocViewerComponent.drawNodes (doc-viewer.component.ts:265)
    at SmartMasteringDocViewerComponent.render (doc-viewer.component.ts:233)
    at SafeSubscriber.eval [as _next] (doc-viewer.component.ts:70)
    at SafeSubscriber.__tryOrUnsub (Subscriber.js:240)
    at SafeSubscriber.next (Subscriber.js:187)

@dmcassel dmcassel added the bug Something isn't working label Jul 12, 2018
@paxtonhare
Copy link
Contributor

@patrickmcelwee do you have any bandwidth to look at this? I stole it from your code? it's an index out of bounds issue.

@patrickmcelwee
Copy link

I am trying to find a second to look at this, yes. Didn't succeed today, but try, try again ;-)

@sfc-gh-rpughsley
Copy link

I've just discovered the same error - any update as we may be showing this to a prospect next week..

@dmcassel
Copy link
Contributor

@danielholgate @robpml can you provide a series of steps to reproduce?

@danielholgate
Copy link
Author

Watch this video from 27:22 to 31:40 :)

https://www.youtube.com/watch?v=LSUGNCLXhZY

@patrickmcelwee
Copy link

I am trying to reproduce on a fresh install from develop, but when I go to the search screen, I get the error:

Local message: search failed: Bad Request. Server Message: REST-INVALIDPARAM: (err:FOER0000) Invalid parameter: No configured options: smart-mastering-core-options

What should I run to install those?

@patrickmcelwee
Copy link

From the examples/smart-mastering directory, I ran ./gradlew mlDeploy, which did not fix this error (and also an error about the mastering-stats extension not being available). But this did:

./gradlew mlPrepareRestApiDependencies
./gradlew -i mlLoadModules

I can't explain it. ;-)

@patrickmcelwee
Copy link

OK, I do think I need more information to reproduce this. Specifically, which data do I load, and which harmonization and smart-mastering flows do I run?

@sfc-gh-rpughsley
Copy link

I've just followed all the steps for deploying the smart-mastering demo - the dev branch. After gradle runui, I access through localhost:4200, get the smart mastering screen to appear, search for 'pollak' and then compare, and merge the 2 results.

The graphic does not display as expected.

1st error, when clicking on compare (from firefox web console)

XML Parsing Error: syntax error
Location: http://localhost:4200/#/compare?uris=%2FOracle%2FPerson%2F3167991399.xml&uris=%2FCRM%2FPerson%2F1044.xml
Line Number 1, Column 1:

clicking on merge gives this

XML Parsing Error: syntax error
Location: http://localhost:4200/#/compare?uris=%2FOracle%2FPerson%2F3167991399.xml&uris=%2FCRM%2FPerson%2F1044.xml
Line Number 1, Column 1: localhost:4200:1:1
XML Parsing Error: syntax error
Location: http://localhost:4200/#/view-sm?docUri=%2Fcom.marklogic.smart-mastering%2Fmerged%2F1565d37a-615f-4ed9-9448-4b57e30d0edd.xml
Line Number 1, Column 1: localhost:4200:1:1
ERROR Error: "missing: 3"
findwebpack-internal:///./node_modules/d3-sankey/src/sankey.js:52:20computeNodeLinkswebpack-internal:///./node_modules/d3-sankey/src/sankey.js:130:62computeNodeLinkswebpack-internal:///./node_modules/d3-sankey/src/sankey.js:126:5sankeywebpack-internal:///./node_modules/d3-sankey/src/sankey.js:68:5drawNodeswebpack-internal:///./src/main/ui/app/smart-mastering/doc-viewer/doc-viewer.component.ts:251:21renderwebpack-internal:///./src/main/ui/app/smart-mastering/doc-viewer/doc-viewer.component.ts:224:17subwebpack-internal:///./src/main/ui/app/smart-mastering/doc-viewer/doc-viewer.component.ts:58:17__tryOrUnsubwebpack-internal:///./node_modules/rxjs/_esm5/Subscriber.js:245:13nextwebpack-internal:///./node_modules/rxjs/_esm5/Subscriber.js:192:17_nextwebpack-internal:///./node_modules/rxjs/_esm5/Subscriber.js:133:9nextwebpack-internal:///./node_modules/rxjs/_esm5/Subscriber.js:97:13_tryProjectwebpack-internal:///./node_modules/rxjs/_esm5/operators/zip.js:192:9checkIteratorswebpack-internal:///./node_modules/rxjs/_esm5/operators/zip.js:174:13notifyNextwebpack-internal:///./node_modules/rxjs/_esm5/operators/zip.js:284:9_nextwebpack-internal:///./node_modules/rxjs/_esm5/InnerSubscriber.js:27:9nextwebpack-internal:///./node_modules/rxjs/_esm5/Subscriber.js:97:13_nextwebpack-internal:///./node_modules/rxjs/_esm5/operators/tap.js:91:13nextwebpack-internal:///./node_modules/rxjs/_esm5/Subscriber.js:97:13_nextwebpack-internal:///./node_modules/rxjs/_esm5/operators/map.js:88:9nextwebpack-internal:///./node_modules/rxjs/_esm5/Subscriber.js:97:13_nextwebpack-internal:///./node_modules/rxjs/_esm5/operators/filter.js:92:13nextwebpack-internal:///./node_modules/rxjs/_esm5/Subscriber.js:97:13notifyNextwebpack-internal:///./node_modules/rxjs/_esm5/operators/mergeMap.js:156:13_nextwebpack-internal:///./node_modules/rxjs/_esm5/InnerSubscriber.js:27:9nextwebpack-internal:///./node_modules/rxjs/_esm5/Subscriber.js:97:13node_modulesangular/common/esm5/http.js:2310:21invokeTaskwebpack-internal:///./node_modules/zone.js/dist/zone.js:421:17node_modulesangular/core/esm5/core.js:4956:24invokeTaskwebpack-internal:///./node_modules/zone.js/dist/zone.js:420:17runTaskwebpack-internal:///./node_modules/zone.js/dist/zone.js:188:28invokeTaskwebpack-internal:///./node_modules/zone.js/dist/zone.js:495:24invokeTaskwebpack-internal:///./node_modules/zone.js/dist/zone.js:1536:9globalZoneAwareCallbackwebpack-internal:///./node_modules/zone.js/dist/zone.js:1562:17 core.js:1448
defaultErrorLogger
core.js:1448
ErrorHandler.prototype.handleError
core.js:1509
next
core.js:5497:117
EventEmitter.prototype.subscribe/schedulerFn<
core.js:4331:34
SafeSubscriber.prototype.__tryOrUnsub
Subscriber.js:240
SafeSubscriber.prototype.next
Subscriber.js:187
Subscriber.prototype._next
Subscriber.js:128
Subscriber.prototype.next
Subscriber.js:92
Subject.prototype.next
Subject.js:56
EventEmitter.prototype.emit
core.js:4311:22
onHandleError/<
core.js:4771:48
ZoneDelegate.prototype.invoke
zone.js:388
Zone.prototype.run
zone.js:138
NgZone.prototype.runOutsideAngular
core.js:4697:47
onHandleError
core.js:4771
ZoneDelegate.prototype.handleError
zone.js:392
Zone.prototype.runTask
zone.js:191
ZoneTask.invokeTask
zone.js:495
invokeTask
zone.js:1536
globalZoneAwareCallback
zone.js:1562

@dmcassel
Copy link
Contributor

@patrickmcelwee did you follow the steps listed in the Smart Mastering example README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants