Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for language maintainers #3919

Closed
1 of 23 tasks
jbrazio opened this issue May 30, 2016 · 26 comments
Closed
1 of 23 tasks

Looking for language maintainers #3919

jbrazio opened this issue May 30, 2016 · 26 comments

Comments

@jbrazio
Copy link
Contributor

jbrazio commented May 30, 2016

We need your help, Marlin has a lot of language packs and we need to create a language team that will be responsible for having the translations up to date. Please answer to this issue with the language you would like to maintain, but be aware we prefer native speakers. We would like to have at least three people per supported language.

When a developer adds a new English string, he should ping the language team by tagging @MarlinFirmware/language-team.

@jbrazio
Copy link
Contributor Author

jbrazio commented May 31, 2016

@barus93 can we count with you for Italian ?
@rafacouto can we count with you for Galician ?
@gege2b can we count with you for French ?
@koldoartola, @MatixYo can we count with you for Basque-Euskera ?
@RicardoGA, @fbarcenas can we count with you for Spanish ?
@AnHardt, @Blue-Marlin, @CONSULitAS can we count with you for German ?
@DavidBjerreBjoerklund, @benj4560 can we count with you for Danish ?
@pixatintes can we count with you for Catalan ?
@danielmartinez can we count with you for Aragonese ?

@danielmartinez
Copy link
Contributor

Yes please, count with me for Aragonese, but in several days.
El 31 may. 2016 14:21, "João Brázio" notifications@github.com escribió:

@barus93 https://github.com/barus93 can we count with you for Italian ?
@rafacouto https://github.com/rafacouto can we count with you for
Galician ?
@gege2b https://github.com/gege2b can we count with you for French ?
@koldoartola https://github.com/koldoartola, @MatixYo
https://github.com/MatixYo can we count with you for Basque-Euskera ?
@RicardoGA https://github.com/RicardoGA, @fbarcenas
https://github.com/fbarcenas can we count with you for Spanish ?
@AnHardt https://github.com/AnHardt, @Blue-Marlin
https://github.com/Blue-Marlin, @CONSULitAS
https://github.com/CONSULitAS can we count with you for German ?
@DavidBjerreBjoerklund https://github.com/DavidBjerreBjoerklund,
@benj4560 https://github.com/benj4560 can we count with you for Danish ?
@pixatintes https://github.com/pixatintes can we count with you for
Catalan ?
@danielmartinez https://github.com/danielmartinez can we count with you
for Aragonese ?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3919 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ADpXk4WsMqcNUm8ekkmQlVDiBTSzPp5hks5qHCe5gaJpZM4IqBMD
.

@jbrazio
Copy link
Contributor Author

jbrazio commented May 31, 2016

@danielmartinez we're just building the teams.

@rafacouto
Copy link
Contributor

Of course, I'll translate defines into Galician :-)

@RicardoGA
Copy link
Contributor

@jbrazio of course, I can help with Spanish

@fbarcenas
Copy link

@jbrazio Of course!

@barus93
Copy link
Contributor

barus93 commented May 31, 2016

@jbrazio ok, i can help with italian..

@jbrazio
Copy link
Contributor Author

jbrazio commented May 31, 2016

@boelle we have a script to do it, but has to be ran manually.
Have a look here.

@Roxy-3D
Copy link
Member

Roxy-3D commented May 31, 2016

We have a lot of hard coded English strings. Especially in Marlin_main.cpp. (Just look at the M48: code. I'm the guilty party on that one!) We might want to clean that up too.

@clexpert
Copy link
Contributor

We will maintain Czech language as we did.

@clexpert
Copy link
Contributor

@jbrazio We have complete Czech language with no problem. All translates on time. Please use @clexpert and @petrzjunior for Czech language as sufficient solution. You can tick this language.

@Blue-Marlin
Copy link
Contributor

Dear @Roxy-3DPrintBoard
M48 has no display messages. Only display messages are translated. All serial output is in English. All strings used for the serial output 'should' be in 'language.h' - not 'language_en.h'. There is no need for immediate action - just if someone is bored he/she could clean up a bit.

@thinkyhead
Copy link
Member

@boelle Here you go…#3936. Looking forward to that Danish!

@CONSULitAS
Copy link
Contributor

@jbrazio
German is fine for me 😄

@CONSULitAS
Copy link
Contributor

@jbrazio
BTW: There was a complain about not translated strings in German.
Many technical terms are the same words in German like in English.
So perhaps we should add a comment like 'intentionally untranslated' to those.

@CONSULitAS
Copy link
Contributor

@jbrazio
How about groups for the language teams?
So you could write @team-german to get them.

@Roxy-3D
Copy link
Member

Roxy-3D commented Jun 1, 2016

This will result in a lot of clutter and complexity. By that same thinking, we will need Code-Maintainers-PreProcessor-Bugs as well as Code-Maintainers-Header-Files etc. etc. I'm not trying to be overly negative, but lets see if we have too many messages going to the Language-Team. If so, we certainly can rethink this. But my guess is even if you are not involved in a particular language's support, you might want to see what the issues are and what the decisions are in the other languages. Right?

@AnHardt
Copy link
Member

AnHardt commented Jun 1, 2016

Pleas avoid that overhead.
If i see a need for a change in any file i'll do it, or will ask for help, anyway.
If it would be someones duty, i'd stay away.

Indeed the unbearable German language file, from ending 2014 was the first thing i wanted to change and was the reason for beginning with Marlin programming. :-)

@jbrazio
Copy link
Contributor Author

jbrazio commented Jun 2, 2016

I plan to have all the people related with language on a "global" language team as I agree with Roxy and Andreas, it will be a clutter for now and usually when we need to add a new string, it must be added to all languages.

@AnHardt may I add you for German then ? :-)

@AnHardt
Copy link
Member

AnHardt commented Jun 2, 2016

@jbrazio
No. Someone includes me.

@rafacouto
Copy link
Contributor

Should we translate in the RCBugFix branch? Marlin or MarlinDev repo? I miss a little translator guide (excuse me if it already exists O:) in order to assist new maintainers and non git-ninjas...

@Roxy-3D
Copy link
Member

Roxy-3D commented Jun 2, 2016

MarlinDev is going away. RCBugFix is the correct place because what ever is there is going forward. And just for right now, during this release cycle, the RC branch is acting as 'Stable' and probably doesn't get the change applied to it.

@petrzjunior
Copy link
Contributor

So now, I think it's the right time to discuss some future plans.
Will the string be translated on every PR someone defines a new string? Or before every release (say every mothly release) we translate all the string that were added since the last one (maybe push against one fork and track progress in one PR)?

@jbrazio
Copy link
Contributor Author

jbrazio commented Jun 2, 2016

Usually we need to translate a new string when a new feature is added.. up to now the developer adds the string into the English file and (which I do not agree) adds the same define in English on all other languages. The ideia is when a new string is added on the PR we just ping @MarlinFirmware/language-team informing there is a new string that must be translated.

@jbrazio jbrazio closed this as completed Jun 3, 2016
@thinkyhead
Copy link
Member

thinkyhead commented Jun 4, 2016

and (which I do not agree) adds the same define in English on all other languages

This is specifically designed to annoy language maintainers into fixing it. 😝 But also, helps ensure the strings are in the same relative position in all language files.

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests