Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unique numbers #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

unique numbers #73

wants to merge 1 commit into from

Conversation

trujivan
Copy link
Collaborator

@trujivan trujivan commented May 22, 2020 •
edited

small script to check the total of non-duplicate phone values

Pull Request Naming Standard

Folder Name - File Name - Change Made

Example: .github - PULL_REQUEST_TEMPLATE.md - Update Template Standards

Description

Please include a summary of the changes and issues fixed. Include any relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ -] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test X
  • Test Y

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

unique numbers
a710420 
small script to check the total of non-duplicate phone values
@trujivan trujivan assigned Marwan01 and trujivan and unassigned Marwan01 May 22, 2020
@trujivan trujivan requested a review from Marwan01 May 22, 2020 03:41
@trujivan trujivan added the enhancement New feature or request label May 22, 2020
@trujivan trujivan linked an issue May 22, 2020 that may be closed by this pull request
Pull up twillio metrics report via admin route #42
Open
@trujivan trujivan removed a link to an issue May 22, 2020
Pull up twillio metrics report via admin route #42
Open
Marwan01
Marwan01 reviewed May 31, 2020
View reviewed changes
docs/cli-dat/uniqueNumbers.py
client = Client("", "")

#Fetching messages from cli
def get_total_exchanged():
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexAndrei98 Can you take a look at this and see if you can return it via text?

@Marwan01 Marwan01 linked an issue May 31, 2020 that may be closed by this pull request
create admin sms route #60
Closed
@Marwan01
Copy link
Owner

Marwan01 commented Jun 9, 2020

In order to be able to text it back, take a look at how it is handled for Advice and News in twillio_utils.py in this screenshot:
Screen Shot 2020-06-09 at 9 52 18 AM
Then just copy your new function into twillio_utils.py file, and create a new elif block where you invoke your function. Feel free to run locally to test it.

@Marwan01 Marwan01 linked an issue Jun 9, 2020 that may be closed by this pull request
Pull up twillio metrics report via admin route #42
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marwan01 Marwan01 Marwan01 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@trujivan trujivan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pull up twillio metrics report via admin route create admin sms route
2 participants
@trujivan @Marwan01