Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the "meeting point" arrow always visible #239

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Make the "meeting point" arrow always visible #239

wants to merge 2 commits into from

Conversation

Rampoina
Copy link
Contributor

@Rampoina Rampoina commented Aug 4, 2022

  • Makes the meeting point arrow always visible
  • Removes the alpha gradient (otherwise the start of the arrow is not visible if it's too far away)
  • Makes the arrow a bit slimmer and the arrowhead bigger to improve visual readability

Fixes #238

Rampoina added 2 commits August 4, 2022 18:02
Make the "meeting point" arrow always visible
8b7655f 
Removes the alpha gradient
Makes the arrow a bit slimmer and the arrowhead bigger to improve visual
readability
Add inverse gradient
79011ac 
now the arrow fades when close to the building
@titiger
Copy link
Member

titiger commented Aug 24, 2022

I don't like the always visible arrow that much maybe you can suggest something else ? Something like slightly transparent arrow on start and less transparent on target ? maybe combined with thinner arrows ?
Maybe show a screenshot(s) so We can quickly decide together if its good.

@Rampoina
Copy link
Contributor Author

@titiger
First of all, as I've discussed with you this is a usability issue. If you don't see where the arrow goes you may wonder if you set the "meeting point" at all, causing users to doubt themselves and having to re-set "meeting points". Usability > (subjective) taste

Second of all, if we're talking exclusively aesthetics the arrow is ugly, always visible or not. The prettier solution would be to use a flag like in 0ad.

Third of all, I've already sent screenshots with 2 different prototypes (one of which is the last commit) on the irc channel:

Here's an animated "meeting point" indicator I made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The building rally point is not visible beyond a certain distance.
2 participants
@Rampoina @titiger